Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Allow one to specify python version #74517

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Makefile: Allow one to specify python version #74517

merged 1 commit into from
Apr 30, 2021

Conversation

relrod
Copy link
Member

@relrod relrod commented Apr 30, 2021 •
edited

/cc @Spredzy

SUMMARY

Change:

  • Allow overriding python version as env var for Makefile
  • Including hacking directory in git export, for manpage generation

Test Plan:

  • Tested as part of recent downstream work
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

releng

@Spredzy @relrod
Makefile: Allow one to specify python version
b7f18cc 
Change:
- Allow overriding python version as env var for Makefile
- Including hacking directory in git export, for docs build

Test Plan:
- Tested as part of recent downstream work
@ansibot ansibot added affects_2.12 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 30, 2021
@bcoca bcoca merged commit 38fb051 into ansible:devel Apr 30, 2021
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 30, 2021
relrod added a commit to relrod/ansible that referenced this pull request May 1, 2021
@relrod @Spredzy
Makefile: Allow one to specify python version (ansible#74517)
bfb5c4a 
Change:
- Allow overriding python version as env var for Makefile
- Including hacking directory in git export, for docs build

Test Plan:
- Tested as part of recent downstream work

Co-authored-by: Yanis Guenane <yguenane@gmail.com>
relrod added a commit that referenced this pull request May 17, 2021
@relrod @Spredzy
Makefile: Allow one to specify python version (#74517) (#74528)
a9b7625 
Change:
- Allow overriding python version as env var for Makefile
- Including hacking directory in git export, for docs build

Test Plan:
- Tested as part of recent downstream work

Co-authored-by: Yanis Guenane <yguenane@gmail.com>
@ansible ansible locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
affects_2.12 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@relrod @webknjaz @bcoca @ansibot @Spredzy